[deprecation] Deprecate ScalarValueToConstFetchRector - #8344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
ScalarValueToConstFetchRector.The rule subscribes to every
String_,Int_andFloat_node in the project and compares the raw value. There is no context check, so the same value in an unrelated place is replaced too:final class SomeClass { public function run(array $items) { - $timeout = 10; + $timeout = \SomeClass::FOOBAR_INT; // unrelated, but replaced as well - return array_slice($items, 0, 10); + return array_slice($items, 0, \SomeClass::FOOBAR_INT); } }The same happens with strings used as array keys, version numbers or messages. There is no way to configure a narrower target, so the rule cannot be made safe by configuration.
Use a custom rule scoped to the exact context (a specific argument, property or method) instead.
The rule now implements
DeprecatedInterfaceand throws inrefactor(). TheScalarValueToConstFetchvalue object is kept, so existing configs still load.